-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export the types crate contents #1674
Conversation
The "Validate external types appearing in public API" jobs fail on this, even though we specifically have this exception in the crate metadata:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1674 +/- ##
==========================================
+ Coverage 95.90% 95.92% +0.02%
==========================================
Files 78 78
Lines 16083 16660 +577
==========================================
+ Hits 15424 15981 +557
- Misses 659 679 +20 ☔ View full report in Codecov by Sentry. |
I think this needs
(I don't particularly understand the distinction.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I can take care of starting that up if nobody else is dying to do it :-) |
|
Fixes #1662. (I think this should be on the list for backporting to 0.22.1.)